Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users: fix lint error manual_unwrap_or_default on OpenBSD #6772

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

lcheylus
Copy link
Contributor

@lcheylus lcheylus commented Oct 7, 2024

Fix #6771


No error for users tool on OpenBSD with clippy

$ cargo clippy --all-targets -puu_users -- -W clippy::manual_string_new -D warnings
(...)
    Checking uucore v0.0.27 (/home/fox/dev/rust-coreutils.git/src/uucore)
    Checking uu_users v0.0.27 (/home/fox/dev/rust-coreutils.git/src/uu/users)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.90s

Fix uutils#6771

Signed-off-by: Laurent Cheylus <foxy@free.fr>
@sylvestre
Copy link
Contributor

it would be great to have a CI like freebsd :)

@lcheylus
Copy link
Contributor Author

lcheylus commented Oct 7, 2024

I have a working CI for OpenBSD in my coreutils fork (currently, 1 test failure on OpenBSD => needs to be fixed) :) https://github.com/lcheylus/rust-coreutils/actions/workflows/openbsd.yml

I'm still waiting comments on my proposal to update FreeBSD CI before submitting a PR to add OpenBSD CI, see #5797

@sylvestre
Copy link
Contributor

sorry, i missed your questions. don't hesitate to ping me quickly in the future. Désolé!

@sylvestre sylvestre merged commit fae477b into uutils:main Oct 7, 2024
68 checks passed
@lcheylus lcheylus deleted the openbsd-users-clippy branch October 7, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clippy error manual_unwrap_or_default on OpenBSD for users tool
2 participants