uucore: Add getsid for process.rs
#6600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the manpage of `getsid` we can find that the syscall may failed and set errno, so we have to process those case.
uucore: Fix tests failure for `test_getsid` uucore: Fix tests failure for `test_getsid`
Suggestions from @BenWiederhake , very thanks!
BenWiederhake
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
LGTM, and the only remaining failures are #6534 and for some reason one of the fuzzers generates infinite output and the job got canceled. Looks unrelated, just a badly-written fuzzing test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I closed pr by mistake :( #6590
This pr will add getsid function for process.rs to detect the session ID of pid.
The session ID plays a full role, and he usually plays the role of a process group identifier on Linux systems (or is it the POSIX standard?). The session ID plays a full role as a kind of process group identifier. In addition to that, this pr will also fulfill the role of getting the session leader.
However, because of the need to call libc, the pr involves unsafe code, so this pr will be ready for review after due consideration.