-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mv: gnu test case to-symlink
fix
#6578
Conversation
GNU testsuite comparison:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, and the test would detect most types of bugs. Great!
The remaining CI failures are unrelated issues: GNU test timeout
is flaky, #6534, #6570 (both).
Can I ask you to improve the error message though? Right now it's very cryptic. Also, the test could use an additional check, just to make extra sure that we will never accidentally overwrite other_fs_file.txt
or something.
GNU testsuite comparison:
|
Looks good, the only remaining CI failure is unrelated: #6534. I'm a bit unhappy about the many fully-qualified usages of various traits/structs, like If you can come up with a nicer way in the future, please do create a PR :) |
okay, I will try 😃 |
tries to fix #6577
Behaviors changed