-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
printf
: Check precision before writing into stdout. Fix #1879
#6511
Conversation
GNU testsuite comparison:
|
this is an excellent first PR, bravo :) |
3e370af
to
7dd93c0
Compare
@sylvestre Thx for reviewing. I've |
GNU testsuite comparison:
|
The code keeps failing one of the CI/CD tests. I didn't change anything relevant so I'm assuming that is not my problem. |
GNU testsuite comparison:
|
sry for the messy tree. i made some mistake when merging |
I don't see why the fuzz_seq, false test is failing. Could someone offer me some assistance? |
@sylvestre, could you kindly help me out? I would greatly appreciate it. |
The two failing tests in the CI are unrelated to your PR. |
Thanks for your reply. I fixed the commit tree for a bit. wonder if it's good enough to merge, and how I should request for review. |
88c829f
to
98d26f2
Compare
98d26f2
to
198200a
Compare
…ignedInt, unsigned, or float
198200a
to
7dd36d7
Compare
printf
: Check precision before writing into stdout. Fix #1879
Thanks for your PR! |
This is my first time opening a pull request. Any suggestions would be greatly appreciated, thank you.