Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uucore/checksum: simplify determine_regex() #6500

Merged
merged 1 commit into from
Jun 27, 2024
Merged

uucore/checksum: simplify determine_regex() #6500

merged 1 commit into from
Jun 27, 2024

Conversation

cakebaker
Copy link
Contributor

This PR simplifies the signature of the determine_regex function from:

fn determine_regex(filename: &OsStr, input_is_stdin: bool, lines: &[String]) -> UResult<(Regex, bool)>

to

fn determine_regex(lines: &[String]) -> Option<(Regex, bool)>

@sylvestre sylvestre merged commit 6a489f5 into uutils:main Jun 27, 2024
65 of 68 checks passed
@sylvestre
Copy link
Contributor

nice, thanks

@cakebaker cakebaker deleted the uucore_checksum_simplify_determine_regex branch June 27, 2024 12:12
@BenWiederhake BenWiederhake mentioned this pull request Jul 15, 2024
Open
@BrewTestBot BrewTestBot mentioned this pull request Nov 16, 2024
Merged
@moonfruit moonfruit mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @sylvestre