Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cksum/hashsum: add support of --check with base64 + other improvs #6452

Merged
merged 13 commits into from
Jun 27, 2024
Merged

cksum/hashsum: add support of --check with base64 + other improvs #6452

merged 13 commits into from
Jun 27, 2024

Conversation

sylvestre
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

@sylvestre sylvestre force-pushed the base64 branch 3 times, most recently from e7466a1 to 84bc499 Compare June 4, 2024 21:48
@sylvestre sylvestre requested a review from cakebaker June 4, 2024 21:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

@sylvestre sylvestre force-pushed the base64 branch 2 times, most recently from d2358be to ccbaa57 Compare June 5, 2024 09:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

@sylvestre sylvestre requested a review from cakebaker June 5, 2024 10:15
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/rm/rm2. tests/rm/rm2 is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!
Skipping an intermittent issue tests/rm/rm1 (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre requested a review from cakebaker June 18, 2024 20:58
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

cakebaker
cakebaker reviewed Jun 19, 2024
View reviewed changes
src/uucore/Cargo.toml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

@sylvestre sylvestre requested a review from cakebaker June 22, 2024 07:57
@sylvestre sylvestre requested a review from cakebaker June 25, 2024 19:24
@sylvestre
Adjust identify_algo_name_and_length to return Option<(String, Option…
212ddf7 
…<usize>)> instead of (String, Option<usize>)
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

@cakebaker cakebaker merged commit 9b3b9e8 into uutils:main Jun 27, 2024
67 of 68 checks passed
@cakebaker
Copy link
Contributor

Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

Great :)

@BrewTestBot BrewTestBot mentioned this pull request Nov 16, 2024
Merged
@moonfruit moonfruit mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker Awaiting requested review from cakebaker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @cakebaker