- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Printf: Fix printf hex alternate zero #5811
Printf: Fix printf hex alternate zero #5811
Conversation
GNU testsuite comparison:
|
I would prefer this PR not to be merged as-is if the larger #5783 PR is merged, as it rewrites the parser used in |
@samueltardieu I agree. For clarity, you're suggesting to only keep the |
Yes, and the associated tests. |
I did the octal fix in the first place because It means that if you want to keep a subset of this PR without the octal fix, you can
|
Maybe we could try to merge @samueltardieu's PR first and then merge this. That should make everything alright, shouldn't it? |
790bfa2
to
0648321
Compare
I've rebased this on top of main after merging #5783. |
GNU testsuite comparison:
|
Summary
Code
Fixed an
Related issues:
original : #5810
part of other changes (PR): #5794
part of other changes: #5709
octal similar problem: #5807