Don't throw on duplicate column for shared tables #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abnegate
commented
Aug 12, 2024
| * | ||
| * @return bool | ||
| */ | ||
| abstract public function getSupportForAttributes(): bool; |
Comment on lines
+55
to
+58
| if ($e->getCode() === '42S21' && isset($e->errorInfo[1]) && $e->errorInfo[1] === 1060) { | ||
| throw new DuplicateException($e->getMessage(), $e->getCode(), $e); | ||
| } elseif ($e->getCode() === 1060 && isset($e->errorInfo[0]) && $e->errorInfo[0] === '42S21') { | ||
| throw new DuplicateException($e->getMessage(), $e->getCode(), $e); |
There was a problem hiding this comment.
For future, lets have a better way to identify the exception
christyjacob4
approved these changes
Aug 12, 2024
stnguyen90
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow multiple metadata entries to be updated. Temporary fix until all databases are using shared tables with a single metadata document for all projects.