This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
add retries around iptable rule removal #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! Thanks for doing this .. |
shrinandj
previously approved these changes
May 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #396
This adds basic retries around removing the IPTable rule for kiam-agent when the pod is terminated.
Given the process is exiting anyway, we cannot really 'guarantee' removal, but these retries will make it highly unlikely that a rule is left behind.
The call to
Remove()gets deferred regardless of error anyway, so we might as well retry internally.kiam/cmd/kiam/agent.go
Lines 68 to 70 in 6e07571