Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

switch to using go modules #315

Merged
merged 7 commits into from
Nov 1, 2019
Merged

switch to using go modules #315

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bf8df91
switch to using vgo
nirnanaaa Oct 28, 2019
5bafb1f
update vendor dependencies
nirnanaaa Oct 28, 2019
0fabdd7
add go modules to drone
nirnanaaa Oct 31, 2019
7aaf6be
change environment variable syntax
nirnanaaa Oct 31, 2019
2cf153c
add environment variable to benchmark
nirnanaaa Nov 1, 2019
2d72bf8
add git as build dependency
nirnanaaa Nov 1, 2019
76e560c
change dockerfile logic
nirnanaaa Nov 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 4 additions & 0 deletions .drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,17 @@ pipeline:
test:
secrets: [ codecov_token ]
image: golang:1.12
environment:
GO111MODULE: "on"
commands:
- make test
- make coverage.txt
- ./ci/codecov.sh

benchmarks:
image: golang:1.12
environment:
GO111MODULE: "on"
commands:
- make bench

Expand Down
4 changes: 4 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
FROM golang:1.12-alpine3.10 as build
ENV GO111MODULE=on


RUN apk add --no-cache make
WORKDIR /go/src/github.com/uswitch/kiam
ADD . .
RUN go mod download
Copy link
Contributor

@surajnarwade surajnarwade Nov 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go build takes care of downloading the dependencies, we don't need go mod download

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring mostly to what kubebuilder does in caching docker layers: https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v2/Dockerfile#L8

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, TFS

RUN make bin/kiam-linux-amd64

FROM alpine:3.8
Expand Down
Loading