Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad class loaders for AR and POA&M in ConvertSubcommand #108

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Feb 21, 2023

Committer Notes

Fix bad class loaders for AR and POA&M in ConvertSubcommand classes for #96.

All Submissions:

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made?

@aj-stein-nist aj-stein-nist self-assigned this Feb 21, 2023
@aj-stein-nist aj-stein-nist linked an issue Feb 21, 2023 that may be closed by this pull request
@aj-stein-nist aj-stein-nist changed the base branch from main to develop February 21, 2023 22:42
@aj-stein-nist
Copy link
Contributor Author

@GaryGapinski and @volpet2014, expect a test build later this week. If you can build it yourself and provide feedback, let us know.

@GaryGapinski
Copy link

If you can build it yourself and provide feedback, let us know.

Does that mean we can/could build at this time (post 5d5d39e)?

@aj-stein-nist
Copy link
Contributor Author

If you can build it yourself and provide feedback, let us know.

Does that mean we can/could build at this time (post 5d5d39e)?

Woops, our build system skips stuffing the build into GitHub Storage when the code is on a PR branch. So on that note, here we go!

cli-core-0.3.3-SNAPSHOT-oscal-cli.zip

@aj-stein-nist aj-stein-nist marked this pull request as ready for review February 22, 2023 03:02
@aj-stein-nist aj-stein-nist force-pushed the 96-poam-conversion-from-xml-to-json-creates-an-assessment-plan branch from 264b994 to fb97f53 Compare February 22, 2023 03:04
@aj-stein-nist aj-stein-nist force-pushed the 96-poam-conversion-from-xml-to-json-creates-an-assessment-plan branch from fb97f53 to 4c33d25 Compare February 22, 2023 03:05
@aj-stein-nist aj-stein-nist merged commit 564c276 into develop Feb 22, 2023
aj-stein-nist added a commit that referenced this pull request Apr 17, 2023
* Fix bad class loaders for AR and POA&M in ConvertSubcommand classes for #96.

* Add regression tests and public access function for loaded class name for #96.
@aj-stein-nist aj-stein-nist deleted the 96-poam-conversion-from-xml-to-json-creates-an-assessment-plan branch November 30, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POA&M conversion from XML to JSON creates an assessment-plan
2 participants