Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of --help with missing required command arguments #327

Conversation

david-waltermire
Copy link
Collaborator

Committer Notes

This PR addresses #293 by implementing a two phase approach to parsing command line arguments. The first phase checks if --help or --version is provided, while the second phase handles actual command processing. If --help or --version is found in the first phase, the help or version information will be provided; else, the command execution will proceed.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

…not providing a required command parameter. Resolves usnistgov#293.
@david-waltermire david-waltermire changed the base branch from main to develop February 23, 2024 15:54
@david-waltermire david-waltermire changed the title Issue293 fix help with arguments Fix use of --help with missing required command arguments Feb 23, 2024
@aj-stein-nist aj-stein-nist self-requested a review February 23, 2024 18:43
@david-waltermire david-waltermire added this pull request to the merge queue Mar 14, 2024
Merged via the queue into usnistgov:develop with commit 4ddd632 Mar 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subcommand generate-schema with no arguments and with --help arguments throws
2 participants