Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get generated XML Schema files with correct extension #280

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Get generated XML Schema files with correct extension #280

merged 1 commit into from
Jan 4, 2024

Conversation

aj-stein-nist
Copy link
Collaborator

@aj-stein-nist aj-stein-nist commented Jan 3, 2024 •
edited
Loading

Committer Notes

Resolves #279.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them? Added in the original issue.
  • Have you written new tests for your core changes, as applicable? It is a typo fix but tests can be added up request upon review.
  • Have you included examples of how to use your new feature(s)? It is a typo fix and this should make valid examples work.
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch. This change to the code does not have applicable impact to the website.

@aj-stein-nist aj-stein-nist self-assigned this Jan 3, 2024
@aj-stein-nist
Copy link
Collaborator Author

@david-waltermire I also checked 256 PR with the ongoing refactor and it seemed it does not modify the metaschema-cli project so it is easy to merge without conflict.

@aj-stein-nist aj-stein-nist mentioned this pull request Jan 3, 2024
Merged
6 tasks
aj-stein-nist added a commit to aj-stein-nist/metaschema-java that referenced this pull request Jan 3, 2024
@aj-stein-nist
Add exception with explanation for missing index for usnistgov#280
9fbd7c3
@aj-stein-nist aj-stein-nist mentioned this pull request Jan 3, 2024
Merged
6 tasks
@david-waltermire david-waltermire added this pull request to the merge queue Jan 4, 2024
Merged via the queue into usnistgov:develop with commit a72e73c Jan 4, 2024
1 check passed
aj-stein-nist added a commit to aj-stein-nist/metaschema-java that referenced this pull request Jan 5, 2024
@aj-stein-nist
Add exception with explanation for missing index for usnistgov#280
78aa99f
aj-stein-nist added a commit to aj-stein-nist/metaschema-java that referenced this pull request Jan 5, 2024
@aj-stein-nist
Tests demonstrating clear error reporting for usnistgov#280
d5d2109
aj-stein-nist added a commit to aj-stein-nist/metaschema-java that referenced this pull request Jan 5, 2024
@aj-stein-nist
Tests demonstrating clear error reporting for usnistgov#280
6c986ca
aj-stein-nist added a commit to aj-stein-nist/metaschema-java that referenced this pull request Jan 5, 2024
@aj-stein-nist
Tests demonstrating clear error reporting for usnistgov#280
06b513f
aj-stein-nist added a commit to aj-stein-nist/metaschema-java that referenced this pull request Jan 5, 2024
@aj-stein-nist
Tests demonstrating clear error reporting for usnistgov#280
4820120
github-merge-queue bot pushed a commit that referenced this pull request Jan 19, 2024
@aj-stein-nist
Add exception with clear message about missing index (#282)
2601b73 
* Add exception with explanation for missing index for #280

* Tests demonstrating clear error reporting for #280

* Report name of missing index in error message
@aj-stein-nist aj-stein-nist linked an issue Jan 26, 2024 that may be closed by this pull request
CLI command validate-content using wrong extension for generated XML schemas #279
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-waltermire david-waltermire david-waltermire approved these changes

Assignees

@aj-stein-nist aj-stein-nist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI command validate-content using wrong extension for generated XML schemas
2 participants
@aj-stein-nist @david-waltermire