Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature metaconstraints #250

Conversation

david-waltermire
Copy link
Collaborator

@david-waltermire david-waltermire commented Oct 28, 2023

Committer Notes

This PR does two things:

  1. Adds support for defining a Metaschema module's model as a Metaschema module.
  2. Defines a new constraints format that can target based on a Metapth against the Metaschema module as a Metaschema module.

This involves adding support for usnistgov/metaschema#228, which means this PR depends on usnistgov/metaschema#470, which addresses this issue.

To full support the features of usnistgov/metaschema#228, the following needs to be completed.

  • core: Add core XML model support for choice-group
  • databind: Add code generation support for choice-group
  • databind: Add XML serialization/deserialization support for choice-group
  • databind: Add JSON/YAML serialization/deserialization support for choice-group
  • schema-gen: Add XML schema generation support for choice-group
  • schema-gen: Add JSON schema generation support for choice-group

As a stretch goal, it would be nice to add support for binding customization of the item type used for choice-group, to allow a base class or interface to be used instead of Object as the item item. This base class or interface would need to be implemented by each member of the choice-group.

  • Add support for choice-group binding customization

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@david-waltermire david-waltermire changed the base branch from main to develop November 9, 2023 02:40
@david-waltermire david-waltermire changed the base branch from develop to feature-metaconstraints-2 November 10, 2023 17:50
@david-waltermire david-waltermire deleted the branch remove-feature-metaconstraints-2 November 13, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant