Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature metapath enhancements 20231016 #236

Conversation

david-waltermire
Copy link
Collaborator

@david-waltermire david-waltermire commented Oct 18, 2023

Committer Notes

Adding support for:

Also refactoring Metapath implementation code improving organization and Javadoc documentation.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

Fixed a bug causing Metapath lexer errors to be silently ignored.
… syntax tree classes.

Adjusted Metapath syntax to add support for for, if, range, and extended QNames.
…expression: ().

Added support for Metapath if expressions: if (expr) then (expr) else (expr). There are no tests yet for if expressions.
Added support for Metapath range expressions: intValue to intValue. There are no tests yet for range expressions.
Added support for Metapath quantified expressions: (some | every) $VarName in Expr1 (, $VarName in ExprN)* satisfies ExprS.
Refactored packages for Metapath compact syntax tree implementations.
Implemented Collections interface on ISequence to allow sequences to better participate in collection-oriented methods.
Added proper support for sub-DynamicContexts supporting variable definition in let and quantified expression statements.
Added ANTLR parsing support for for, simple map, and eqname handling. The for and simple map CSTs are not yet implemented. The eqname handling still treats these as simple names. Future work will implement proper QName support.
Cleaned up static and dynamic exceptions.
Cleaned up and documented loader interfaces.
Added a range JUnit test.
Reduced PMD warnings.
@david-waltermire david-waltermire marked this pull request as ready for review October 19, 2023 04:46
@david-waltermire david-waltermire force-pushed the feature-metapath-enhancements-20231016 branch from cafd56d to 1da092a Compare October 19, 2023 05:27
@david-waltermire david-waltermire merged commit f8abaa5 into usnistgov:develop Oct 19, 2023
@david-waltermire david-waltermire deleted the feature-metapath-enhancements-20231016 branch October 19, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant