Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECDSA vector set issue #52

Closed
Kritner opened this issue Dec 9, 2020 · 4 comments
Closed

ECDSA vector set issue #52

Kritner opened this issue Dec 9, 2020 · 4 comments
Assignees

Comments

@Kritner
Copy link
Contributor

Kritner commented Dec 9, 2020

Thanks, @Kritner. And our lab user found another two vector sets with the same error when testing with DCDSA. Not sure if they are having the same issue. If not I may need to open up another issue.

/acvp/v1/testSessions/129146/vectorSets/393177

/acvp/v1/testSessions/129146/vectorSets/393180

Originally posted by @AndrewHYang in #46 (comment)

@Kritner Kritner self-assigned this Dec 9, 2020
@Kritner
Copy link
Contributor Author

Kritner commented Dec 9, 2020

The data in both of the vector sets response files is malformed:

{
"tcId": 1,
"testPassed = ": "true"
},

the above example of bad responses exists in both vector set files.

@AndrewHYang
Copy link

For the ECDSA, our lab users got the formatting issues resolved. However, they got the error below again from HMAC. Since the previous was closed, I attach here anyway. Is it due to the same issue?

"error": "A task was canceled."

Example:
Demo server
Test session: /acvp/v1/testSessions/131631
Vector set: /acvp/v1/testSessions/131631/vectorSets/406502

@Kritner
Copy link
Contributor Author

Kritner commented Dec 21, 2020

The previous issue being: #46 correct? I'd prefer to update that issue since it seems related. I'll bump that issue with the additional information from your previous comment #52 (comment)

If the ECDSA issue resolved? I know it seems like we need to have better handling on when a file is malformed, but that will be a longer term fix, that is at least on our radar.

@Kritner
Copy link
Contributor Author

Kritner commented Jan 8, 2021

I'm assuming this is all taken care of, but feel free to reopen and/or bump if not.

@Kritner Kritner closed this as completed Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants