-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solved issue #3533 by editing the label "create a new Twitter applica… #3840
Conversation
… application" Solved issue ushahidi#3533 by editing the label "create a new Twitter application" I added the sentences "Twitter applications may take a few hours or a few days to be approved by Twitter. Please be aware of this if you need this data quickly.',.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jenniline Looks good but could you remove the " before Twitter? See comment in the code?
@@ -71,9 +71,10 @@ public function getOptions() | |||
{ | |||
return [ | |||
'intro_step1' => [ | |||
'label' => 'Step 1: Create a new Twitter application', | |||
'label' => 'Step 1: Create a new Twitter application.<br /> "Twitter applications may take a few hours or a few days to be approved by Twitter. <br />Please be aware of this if you need this data quickly.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jenniline Thank you for making this change! Could you just remove the " before Twitter? Thank you 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. I am on it
Commit to removing the extra " before Twitter I removed the extra (") as Anna requested. I removed it from the Twitter.php file
@Jenniline One last thing, can you change the text to "few hours or days"? Thank you! |
@Jenniline Also, could you remove the |
Hi Anna, I don't see any "?" do you mean the " |
I changed the words "a few hours or a few days" and removed the <br /> as requested by @Anagamanga
Hi, Anna I just made the Pull request please check it out. Thanks |
@Jenniline I meant |
Hi Anna, I had imagined that is what you meant and I made the change yesterday. The pull request is still here under this same branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine now! Thank you for your contribution 🎉
@all-contributors please add @Jenniline for code |
I've put up a pull request to add @Jenniline! 🎉 |
…tion"
Solved issue #3533 by editing the label "create a new Twitter application"
I added the sentences "Twitter applications may take a few hours or a few days to be approved by Twitter. Please be aware of this if you need this data quickly.',.
This pull request makes the following changes:
-Adds a label that informs users of the lengthy process involved in create a Twitter application
Test checklist:
[ ]
I certify that I ran my checklist
Fixes #3533 .
Ping @ushahidi/platform