Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(disablemedia): when we call the formatter for media we call racks… #3832

Merged
merged 2 commits into from
Jan 10, 2020
Merged

fix(disablemedia): when we call the formatter for media we call racks… #3832

merged 2 commits into from
Jan 10, 2020

Conversation

rowasc
Copy link
Contributor

@rowasc rowasc commented Jan 10, 2020

…pace, and /media is useless

This pull request makes the following changes:

Test checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

tuxpiper
tuxpiper approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@tuxpiper tuxpiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all makes sense to me 👍 The operation is expensive and I don't see a point for it.

@rowasc rowasc merged commit f2e61fc into develop Jan 10, 2020
@tuxpiper tuxpiper deleted the disable-media-all branch March 24, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuxpiper tuxpiper tuxpiper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rowasc @tuxpiper