-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1 Solving issue #3533 #1422
1 Solving issue #3533 #1422
Conversation
Adding a description on setting up a new twitter application for users. The description informs them that the process is lengthy so they don't get disappointed. I have made the edit to the en.json file as described in the problem description.
Hey @Jenniline, It looks like you haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
Hey @Jenniline thank you for taking on this issue! It's great to see you committing to the repo again ❤️ So you have: "intro_step_1": "Step 1: Create a new Twitter application", Can we change the 2nd "intro_step_1": to "intro_step_2": and the the visible text to Step 2: I also think we can shorten the copy to "Twitter applications may take a few hours or So just removing the second 'a few' Great work! |
Hi @Erioldoesdesign if you look keenly at my Pull request I have completely erased the line "intro_step_1": "Step 1: Create a new Twitter application", If I do what you are suggesting there might not be chronology in the workflow of the twitter section because intro_step_2 might appear twice since it is already written at the point But for now I have made another pull request for the issue with the changes I have made. @Erioldoesdesign and @rowasc please review and let me know. Thanks |
Ah thanks Jenniline! I completely overlooked the red 'deleted' line 🤦♂ my bad! thanks for this/the new pull request~ |
@Jenniline It looks good but the "few days" is still there in the code, you need to make a commit into this branch ("patch-1") in order for it to show up. |
This commit removes the words "a few" days from the description of the lengthy process. This was to perform the corrections mentioned by Anna from my last commit on the 6th of Feb 2020
Hi, Anna I have made a commit to "patch-1" with the changes you requested. here is the link Please review. Thanks |
@@ -1119,7 +1119,7 @@ | |||
} | |||
}, | |||
"twitter": { | |||
"intro_step_1": "Step 1: Create a new Twitter application", | |||
"intro_step_1": "Step 1: Create a new Twitter application: <br />Twitter applications may take a few hours or days to be approved by Twitter.<br />Please be aware of this if you need this data quickly.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jenniline One more thing, could you remove the " in the end of the sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, I missed there are a " in the beginning, forget my comment! Merging! Thank you for your contribution! 🎉
Adding a description on setting up a new twitter application for users.
The description informs them that the process is lengthy so they don't get disappointed.
I have made the edit to the en.json file as described in the problem description.
This pull request makes the following changes:
-Adding a description on setting up a new twitter application for users.
-The description informs them that the process is lengthy so they don't get disappointed.
Testing checklist:
[ ]
I certify that I ran my checklist
Fixes ushahidi/platform#3533 .
Ping @ushahidi/platform