Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 Solving issue #3533 #1422

Merged
merged 2 commits into from
Feb 7, 2020
Merged

1 Solving issue #3533 #1422

merged 2 commits into from
Feb 7, 2020

Conversation

Jenniline
Copy link
Contributor

@Jenniline Jenniline commented Feb 5, 2020

Adding a description on setting up a new twitter application for users.
The description informs them that the process is lengthy so they don't get disappointed.
I have made the edit to the en.json file as described in the problem description.

This pull request makes the following changes:
-Adding a description on setting up a new twitter application for users.
-The description informs them that the process is lengthy so they don't get disappointed.

Testing checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes ushahidi/platform#3533 .

Ping @ushahidi/platform

Adding a description on setting up a new twitter application for users.
The description informs them that the process is lengthy so they don't get disappointed.
I have made the edit to the en.json file as described in the problem description.
@ushbot
Copy link
Collaborator

ushbot commented Feb 5, 2020

Hey @Jenniline,
thank you for your Pull Request.

It looks like you haven't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@Erioldoesdesign
Copy link

Hey @Jenniline thank you for taking on this issue! It's great to see you committing to the repo again ❤️

So you have:

"intro_step_1": "Step 1: Create a new Twitter application",
"intro_step_1": "Step 1: Create a new Twitter application: Twitter applications may take a few hours or a few days to be approved by Twitter. Please be aware of this if you need this data quickly.",

Can we change the 2nd "intro_step_1": to "intro_step_2": and the the visible text to Step 2:

I also think we can shorten the copy to "Twitter applications may take a few hours or a few days to be approved by Twitter. Please be aware of this if you need this data quickly.

So just removing the second 'a few'

Great work!

@Jenniline
Copy link
Contributor Author

Jenniline commented Feb 6, 2020

Hi @Erioldoesdesign if you look keenly at my Pull request I have completely erased the line

"intro_step_1": "Step 1: Create a new Twitter application",
and I have replaced it with
intro_step_1": "Step 1: Create a new Twitter application: Twitter applications may take a few hours or a few days to be approved by Twitter. Please be aware of this if you need this data quickly.",

If I do what you are suggesting there might not be chronology in the workflow of the twitter section because intro_step_2 might appear twice since it is already written at the point
"intro_step_2": "Step 2: Generate a consumer key and secret",
Except you want me to insert "intro_step_3" that I can do

But for now
I have cancelled the words "a few" as you requested and I have and left the description for the lengthy process.
Here is the link to the Pull request: Jenniline#3

I have made another pull request for the issue with the changes I have made. @Erioldoesdesign and @rowasc please review and let me know.

Thanks

@Jenniline Jenniline requested a review from rowasc February 6, 2020 16:18
@Erioldoesdesign
Copy link

Ah thanks Jenniline! I completely overlooked the red 'deleted' line 🤦‍♂ my bad! thanks for this/the new pull request~

@Angamanga
Copy link
Collaborator

@Jenniline It looks good but the "few days" is still there in the code, you need to make a commit into this branch ("patch-1") in order for it to show up.

This commit removes the words "a few" days from the description of the lengthy process. 
This was to perform the corrections mentioned by Anna from my last commit on the 6th of Feb 2020
@Jenniline
Copy link
Contributor Author

Hi, Anna I have made a commit to "patch-1" with the changes you requested. here is the link
Jenniline@97bb92b

Please review.

Thanks
Jenniline

@@ -1119,7 +1119,7 @@
}
},
"twitter": {
"intro_step_1": "Step 1: Create a new Twitter application",
"intro_step_1": "Step 1: Create a new Twitter application: <br />Twitter applications may take a few hours or days to be approved by Twitter.<br />Please be aware of this if you need this data quickly.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jenniline One more thing, could you remove the " in the end of the sentence?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I missed there are a " in the beginning, forget my comment! Merging! Thank you for your contribution! 🎉

@Angamanga Angamanga merged commit 141a102 into ushahidi:develop Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting up a Twitter application is a lengthy process for new users
4 participants