3781 validating img #1383
Merged
3781 validating img #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient into 3781-validating-img
rowasc
reviewed
Dec 3, 2019
| @@ -25,7 +25,7 @@ function ( | |||
| template: require('./media.html'), | |||
| link: function ($scope, element, attr, ngModel) { | |||
| // Initialize media object | |||
| $scope.media = { id: null, file: null, caption: '', dataURI: null, changed: false }; | |||
| $scope.media = { id: null, file: null, caption: '', dataURI: null, changed: false}; | |||
There was a problem hiding this comment.
should this have a deleted: false as well?
There was a problem hiding this comment.
Yep, true, they should all be there for clarity. Added it now :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Testing checklist:
Select a post with an image
Delete the image
Do not save the post, navigate away or click cancel
Go to the post again, the image should still be there
Select the post again and edit it
Delete the image
Save the post
Go to the post again, the image is deleted!
Repeat above with a survey with several images
I certify that I ran my checklist
Fixes ushahidi/platform#3781 (part of it) .
Ping @ushahidi/platform