Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show intercom link only if intercomAppId is set #1379

Conversation

ritesh-pandey
Copy link
Contributor

This pull request makes the following changes:

  • Show intercom link only if intercomAppId is set

Testing checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes ushahidi/platform#3769 .

Ping @ushahidi/platform

@ushbot
Copy link
Collaborator

ushbot commented Nov 26, 2019

Hey @ritesh-pandey,
thank you for your Pull Request.

It looks like you haven't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@ritesh-pandey
Copy link
Contributor Author

[clabot:check]

@ushbot
Copy link
Collaborator

ushbot commented Nov 26, 2019

@rjmackay It looks like @ritesh-pandey just signed our Contributor License Agreement. 👍

Always at your service,

clabot

Copy link
Collaborator

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thank you @ritesh-pandey for your contribution 🎉 !

@ritesh-pandey ritesh-pandey marked this pull request as ready for review November 28, 2019 06:19
@Angamanga Angamanga merged commit 0ac1b92 into ushahidi:develop Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong intercom link if intercomAppId is not set
3 participants