Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sortablejs version to 1.10 #1351

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Fix sortablejs version to 1.10 #1351

merged 1 commit into from
Oct 30, 2019

Conversation

aitorres
Copy link
Contributor

@aitorres aitorres commented Oct 18, 2019

This pull request makes the following changes:

  • Pins sortablejs to version 1.10.0 due to greenkeeper filing an issue after testing the build with sortablejs version 1.10.1 (on ##1343)

Testing checklist:

  • Run npm install with the new package.json in order to check that the dependencies are installed successfuly

  • I certify that I ran my checklist

Fixes ushahidi/platform-client#1343 (issue #1343).

Ping @ushahidi/platform

@ushbot
Copy link
Collaborator

ushbot commented Oct 18, 2019

Hey @aitorres,
thank you for your Pull Request.

@rjmackay It looks like this brave person signed our Contributor License Agreement. 👍

Always at your service,

clabot

@Angamanga
Copy link
Collaborator

@aitorres Thank you for working on this issue! Are you done for review?

@aitorres
Copy link
Contributor Author

@aitorres Thank you for working on this issue! Are you done for review?

Sure, @Angamanga!

@rowasc
Copy link
Contributor

rowasc commented Oct 27, 2019

hey, sorry for the delay, we will test this and get back to you this week.
thanks again

Copy link
Contributor

@rowasc rowasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working perfectly. Thank you. Merging

@rowasc rowasc merged commit 34968f3 into ushahidi:develop Oct 30, 2019
@rowasc
Copy link
Contributor

rowasc commented Oct 30, 2019

@all-contributors please add aitorres for code, bug

rowasc added a commit that referenced this pull request Oct 31, 2019
Fix: sortableJS fix for v1.10.0 of sortableJS added in #1351
@aitorres aitorres deleted the aitorres-patch-1 branch March 5, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An in-range update of sortablejs is breaking the build 🚨
4 participants