-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Category Selector Field Bug Fix - Resolves #2455 #1346
Category Selector Field Bug Fix - Resolves #2455 #1346
Conversation
… when categories has length greater than 0
Hey @Guzzler, It looks like you haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
[clabot:check] |
@Guzzler Thank you so much for contributing 🎉 ! I will review this pr and get back to you shortly! |
@Guzzler This works fine and removes the "Select-all" checkbox 👍. Good job! I would like us to remove the Label and the field from the add-post-view entirely, it is still visible (sorry we did not cover this in the instructions). You can remove this by going to the file "app/main/posts/modify/post-value-edit.html". This file is quite complex, but you find the div for this at line 237 in the file. Doing another ng-if there and checking the length of the attribute.options-array there should solve this issue. There are also check-boxes and radio-buttons in this div, and I just realized they have the same problem. The attribute.options-array holds the values for each category, radio-button or check-box and if that array is empty, we don't need that field. Just reach out if you have any questions or get stuck! 🎉 |
…tribute.options array
Have pushed another commit doing the needful. Please let me know if you required something different. I think this should give the desired behavior required. Glad to help and would love to keep contributing! @Angamanga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for quick reply @Guzzler! This looks good and works fine! 👍 You are absolutely welcome to continue contributing, reach out if you want help with selecting your next issue!
@all-contributors please add @Guzzler for code |
This pull request makes the following changes:
Fixes ushahidi/platform#2455 .
Ping @ushahidi/platform @rowasc