Migration/link api #1139
Merged
Migration/link api #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngular/jest incompatibility Link.test.jsx
rjmackay
reviewed
May 10, 2018
app/react-transition/Link.spec.jsx
Outdated
| import Link from "./Link"; | ||
|
|
||
| test("Link accepts a route string, replace bool, id, className, title, and children", () => { | ||
| const component = renderer.create( |
There was a problem hiding this comment.
We probably need to set up a fake angular app before this. So that angular.element(document) returns something useful
event is never received in tests
Mock state and validate calls to state.go
c6ca15f to
4cd6d09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Testing checklist:
Go to /settings/testroute/1 and click the link
you should be taken to data view
Tests fail because of problems with angular and jest
I certify that I ran my checklist
Fixes ushahidi/platform# .
Ping @ushahidi/platform