test(ush-logo test files): got tests working with store data #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made it so that Jest isn't mad at angular and now tests are passing
Checking for store and reassigning props broke connect component; removed and just using plain component instead
crcommons
commented
May 10, 2018
| return <ConnectedWrappedComponent store={store} {...props} />; | ||
| if (!props.store) { | ||
| const injector = angular.element(document).injector(); | ||
| /* eslint-disable no-param-reassign */ |
There was a problem hiding this comment.
I couldn't figure out how to do this so that the linter wouldn't get mad. @rjmackay do you know what to do here?
|
From the jest readme:
Travis only breaks on Node 5. We should just drop support for that and probably add newer version into our matrix too. |
rjmackay
approved these changes
May 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Testing checklist:
Run tests
I certify that I ran my checklist
Fixes ushahidi/platform# .
Ping @ushahidi/platform