Adds exports to package.json #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ekwoka, Thanks for pointing this out. I didn't have a good understanding of the new fields thinking the existing fields should be adequate but I also had been trying to figure out what was the cause of nested imports swapping between cjs/mjs. I'm going to try and fix the CI for external PR's, do a little testing and we will be looking to merge this very quickly! Cheers. |
|
@ekwoka, If you want to try re-pulling develop I think the e2e tests should run correctly now. Cheers. |
Shard
approved these changes
Jan 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #45
The new standard for resolving different exports is with the
exportkey. https://nodejs.org/api/packages.html#package-entry-pointsSome environments will require these to work properly.