Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add native argument support for recurring jobs #105

Merged

Conversation

gsdevme
Copy link
Contributor

@gsdevme gsdevme commented Sep 14, 2020

An attempt to keep the recurring jobs file as a non-breaking change came with a downside that to 'detect' the arguments were assumed too much.

Inturn this created bugs, seems we are forced to change the definition here in-order to prevent further problems

@gsdevme gsdevme force-pushed the fix/add-native-argument-support-for-recurring-jobs branch from d2a8bdd to 0fe5275 Compare September 14, 2020 16:50
@gsdevme gsdevme force-pushed the fix/add-native-argument-support-for-recurring-jobs branch from 0fe5275 to 4560ae7 Compare September 14, 2020 17:15
@calumbrodie calumbrodie merged commit a9a0977 into master Sep 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/add-native-argument-support-for-recurring-jobs branch September 14, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants