#937, #921 improve evaluation of proxy configuration, allow empty port #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… allow empty proxy port
helloanoop
reviewed
Nov 12, 2023
| @@ -203,10 +187,10 @@ const configureRequest = async ( | |||
| const parseDataFromResponse = (response) => { | |||
| const dataBuffer = Buffer.from(response.data); | |||
| // Parse the charset from content type: https://stackoverflow.com/a/33192813 | |||
| const charset = /charset=([^()<>@,;:\"/[\]?.=\s]*)/i.exec(response.headers['Content-Type'] || ''); | |||
| const charset = /charset=([^()<>@,;:"/[\]?.=\s]*)/i.exec(response.headers['Content-Type'] || ''); | |||
There was a problem hiding this comment.
@mirkogolze Is the removal \ intentional ?
There was a problem hiding this comment.
Inside brackets [...] you don't need to escape "
And my IntelliJ really helps me here.
|
Thanks for taking care of this @mirkogolze ! |
This was referenced Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no proxy configuration is given on collection level, check for the global proxy configuration.
Allow empty port for proxy configuration
Contribution Checklist: