Added properties to collections #718

thehorse2000 · 2023-10-21T17:59:38Z

Description

This change introduces storing properties for collections.
Currently, two properties are stored in collections:

BASE URL which will be the initial default value for any new request within that collection
Default Request Type also sets initially the request type for new requests.

This is very helpful to avoid repetition of entering the same URL over and over again.
This also opens up more space for future customizations for the collections.

The collection properties are stored in the bruno.json file of the collection

Contribution Checklist:

The pull request only addresses one issue or adds one feature.
The pull request does not introduce any breaking changes
I have added screenshots or gifs to help explain the change if applicable.
I have read the contribution guidelines.
Create an issue and link to the pull request.

For previous comments of this PR. See #707

Monosnap.screencast.2023-10-21.20-47-15.mp4

helloanoop · 2023-10-22T11:18:55Z

@thehorse2000 Nice!

Fully onboard with supporting this. I

I'd like to recommend a few changes.
The properties modal was kind of inspired by how we have properties of a file or folder in any OS.
I recommend putting this inside the collection settings and calling the Tab Presets
The config can be stored inside bruno.json under the key presets

{
  "presets": {
     "defaultUrl": "",
     "defaultRequestType": "",
  }
}

thehorse2000 · 2023-10-22T12:28:08Z

Hey, Thanks for the info. I actually didn't know there was a collections settings area 😿
I think that is because we can only access it from requests.
I believe it would be better if we could access these settings from the menu of the collection (like properties)
But maybe that is for another PR 😄

thehorse2000 · 2023-10-22T12:37:58Z

New Changes

Changed "properties" to "presets" in bruno.json file
Added Presets tab to collection settings
Returned collection properties modal to its previous state.

Monosnap.screencast.2023-10-22.15-33-14.mp4

helloanoop

@thehorse2000 Nice work. I have a couple more comments. Once these addressed, I feel this should be good to merge.

helloanoop · 2023-10-22T18:19:48Z

packages/bruno-electron/src/ipc/collection.js

@@ -94,6 +94,28 @@ const registerRendererEventHandlers = (mainWindow, watcher, lastOpenedCollection
    }
  });

+  // update collection properties


@thehorse2000 You don't need a new electron event. There is already one which handles the updates for Bruno Config file.

https://github.com/usebruno/bruno/blob/main/packages/bruno-app/src/components/CollectionSettings/index.js#L34-L42

Can you update the code to use that?

helloanoop · 2023-10-22T18:20:50Z

packages/bruno-app/src/components/CollectionSettings/index.js

@@ -114,6 +118,9 @@ const CollectionSettings = ({ collection }) => {
        <div className={getTabClassname('headers')} role="tab" onClick={() => setTab('headers')}>
          Headers
        </div>
+        <div className={getTabClassname('presets')} role="tab" onClick={() => setTab('presets')}>


Lets place this tab after Tests and before Proxy

martinsefcik · 2023-10-22T21:19:38Z

@thehorse2000 @helloanoop Probably this Settings tab for collection could be opened by clicking on collection name in sidebar, the same way how it is working in Postman. It could be then also used to switch quickly environment, because now if I want to run whole collection or folder I have to unfold many subfolders find first request in collection open it and then I can switch environment which is not very user friendly.

Also this Collection properties in modal and Collection settings in tab could be merged to Collection tab. It doeas not make sense to me to have two places in app for similar things.

helloanoop · 2023-10-22T22:03:22Z

Probably this Settings tab for collection could be opened by clicking on collection name

Agreed.

Also this Collection properties in modal and Collection settings in tab could be merged to Collection tab. It doeas not make sense to me to have two places in app for similar things.

Agreed. Thinking of a new Tab called Info which will display the same stuff that we display in Properties

thehorse2000 · 2023-10-23T08:16:45Z

@helloanoop Resolved the required changes.
I do also agree with you and @martinsefcik opinions on making the collections settings page more accessible.
So I will work on it, if you guys don't mind.
Will create a new PR for it and mention you

helloanoop · 2023-11-19T06:54:10Z

Nice work @thehorse2000 !

PR Merged.

helloanoop · 2023-11-19T09:57:04Z

Probably this Settings tab for collection could be opened by clicking on collection name in sidebar

@martinsefcik This is done.

Also this Collection properties in modal and Collection settings in tab could be merged to Collection tab. It doeas not make sense to me to have two places in app for similar things.

This is also done. See #989
I also removed Properties in the collection dropdown and added Settings

It could be then also used to switch quickly environment, because now if I want to run whole collection or folder I have to unfold many subfolders find first request in collection open it and then I can switch environment which is not very user friendly.

@martinsefcik I didn't understand. Can you explain this?
You should be able to select any request and switch the env on the top-right corner right ?

martinsefcik · 2023-11-19T20:41:39Z

Probably this Settings tab for collection could be opened by clicking on collection name in sidebar

@martinsefcik This is done.

Thanks.

It could be then also used to switch quickly environment, because now if I want to run whole collection or folder I have to unfold many subfolders find first request in collection open it and then I can switch environment which is not very user friendly.

@martinsefcik I didn't understand. Can you explain this? You should be able to select any request and switch the env on the top-right corner right ?

@helloanoop If you have for example the following collection structure:

- folder 1
  - folder 1.1
    - folder 1.1.1
      - folder 1.1.1.1
        - request 1
        - request 2
        - ...
- folder 2
  - folder 2.1
    - folder 2.1.1
      - folder 2.1.1.1
        - request a
        - request b
        - ...

then you have to unfold first 4 folders to get inside folder with request, then open request and the switch environment.

So I meant this that it isn't/wasn't very user friendly.

martinsefcik · 2023-11-20T14:39:56Z

Probably this Settings tab for collection could be opened by clicking on collection name in sidebar

@martinsefcik This is done.

@helloanoop I tested 1.2.0 and now I realized that you put this open collection settings action on click event at different place and it does not help much in scenario I described in previous comment (#718 (comment))

Also wouldn't be better to rename this setting tab name from Collection to Settings?
For me collection area is the whole right part (excluding sidebar) of the application screen. And tab itself contains collection settings. So to have Collection in tab name is a bit confusing at least for me :)

garposmack · 2023-11-21T13:52:12Z

I loved this new feature.
It's possible to go one step further, and have folders inside a collection to have the same settings and properties as a collection?

Added properties to collections

36d6d11

thehorse2000 mentioned this pull request Oct 21, 2023

Add most common request url as initial in new req #707

Closed

5 tasks

Added presets to collection settings

cbfd7fa

helloanoop requested changes Oct 22, 2023

View reviewed changes

Amr osama added 2 commits October 23, 2023 11:11

removed custom ipc event

e658629

Changed Presets Tab positioning

03460c5

Merge branch 'main' into feature/add-properties-to-collections

f345155

helloanoop approved these changes Nov 19, 2023

View reviewed changes

helloanoop merged commit 7367972 into usebruno:main Nov 19, 2023
2 checks passed

helloanoop added a commit that referenced this pull request Nov 19, 2023

chore(#718): collcetion presets pr review

bd71ade

helloanoop mentioned this pull request Nov 19, 2023

[Feature] Default environment #303

Open

sanjai0py mentioned this pull request Jul 2, 2024

Collection Location #989

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added properties to collections #718

Added properties to collections #718

thehorse2000 commented Oct 21, 2023 •

edited by helloanoop

Loading

helloanoop commented Oct 22, 2023

thehorse2000 commented Oct 22, 2023

thehorse2000 commented Oct 22, 2023

helloanoop left a comment

helloanoop Oct 22, 2023

helloanoop Oct 22, 2023

martinsefcik commented Oct 22, 2023

helloanoop commented Oct 22, 2023

thehorse2000 commented Oct 23, 2023

helloanoop commented Nov 19, 2023

helloanoop commented Nov 19, 2023

martinsefcik commented Nov 19, 2023 •

edited

Loading

martinsefcik commented Nov 20, 2023

garposmack commented Nov 21, 2023

Added properties to collections #718

Added properties to collections #718

Conversation

thehorse2000 commented Oct 21, 2023 • edited by helloanoop Loading

Description

Contribution Checklist:

helloanoop commented Oct 22, 2023

thehorse2000 commented Oct 22, 2023

thehorse2000 commented Oct 22, 2023

New Changes

helloanoop left a comment

Choose a reason for hiding this comment

helloanoop Oct 22, 2023

Choose a reason for hiding this comment

helloanoop Oct 22, 2023

Choose a reason for hiding this comment

martinsefcik commented Oct 22, 2023

helloanoop commented Oct 22, 2023

thehorse2000 commented Oct 23, 2023

helloanoop commented Nov 19, 2023

helloanoop commented Nov 19, 2023

martinsefcik commented Nov 19, 2023 • edited Loading

martinsefcik commented Nov 20, 2023

garposmack commented Nov 21, 2023

thehorse2000 commented Oct 21, 2023 •

edited by helloanoop

Loading

martinsefcik commented Nov 19, 2023 •

edited

Loading