Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1112 support variables in Generate Code #1118

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

survivant
Copy link
Contributor

@survivant survivant commented Dec 2, 2023

Description

Fixing the issue with the variables in the Generate code from query

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Linked to this issue : #1112

The header is there now, but we still got the issue that the variable are not replace by there value
image

@survivant
Copy link
Contributor Author

now the content of the variable is replaced in the Headers
image

@survivant
Copy link
Contributor Author

Now the variables in the query params are replaced and escaped
image

@survivant survivant changed the title Feature/1112 support variable codegen Feature/1112 support variables in Generate Code Dec 2, 2023
@GarlicPunk
Copy link

Is there any thought expanding this and making an equivalent to req.getBody() that populates the variables? This would incredible useful when attempting to generate HMAC-signatures or any other time that a complete body is required within a pre-request script

@survivant
Copy link
Contributor Author

@GarlicPunk I'm not sure what you are talking about. Can you give me more details please. Also, can you try this branch please. I added few changes there : https://github.com/survivant/bruno/tree/main

@hungdh9x
Copy link

hungdh9x commented Jun 1, 2024

+1

@hungdh9x
Copy link

@survivant can you up-to-date pull request?

@helloanoop @lohxt1 please review this PR :adore:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants