Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1024): Fix validation error on GraphQL request when importing Insomnia collection #1078

Conversation

nelup20
Copy link
Contributor

@nelup20 nelup20 commented Nov 28, 2023

Closes #1024

Description

Changed variables to be an empty string just like query when there's an exception while parsing a GraphQL request.

Before After
bruno_bugfix_1024_before.mp4
bruno_bugfix_1024_after.mp4

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@helloanoop helloanoop merged commit 7d3d543 into usebruno:main Nov 29, 2023
@helloanoop
Copy link
Contributor

Thanks for taking care of this @nelup20 !

@nelup20
Copy link
Contributor Author

nelup20 commented Nov 29, 2023

Thanks for all the merges @helloanoop! I really appreciate your work on Bruno and its welcoming nature (first time contributing to an open source project & I love it 😄)

@nelup20 nelup20 deleted the bugfix/1024-importing_from_a_insomnia_collection branch November 29, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Importing from a Insomnia collection
2 participants