Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (#1038): Handle unquoted variables in JSON Lint #1062

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

n00o
Copy link
Contributor

@n00o n00o commented Nov 26, 2023

Convert unquoted variables in JSON body to 1 in JSON linter. This allows for putting multiple environment/collection variables next to each other and still be unquoted.

Description

This is to fix (#1038) by making the JSON linter replace unquoted variables with 1 so that it passes it's tests and matches what is allowed in the JSON body. It should also fix the prettify check that I failed last commit.
JSON_Uncommented_Variables

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Convert unquoted variables in JSON body to 1 in JSON linter. This allows for putting multiple environment/collection variables next to each other and still be unquoted.
@helloanoop helloanoop merged commit 0e32053 into usebruno:main Nov 27, 2023
@helloanoop
Copy link
Contributor

Nice!
Thanks for taking care of this @n00o !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants