Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1008): JSON Linting Comments #1025

Closed
wants to merge 2 commits into from

Conversation

n00o
Copy link
Contributor

@n00o n00o commented Nov 22, 2023

Strip JSON body of comments and replace them with spaces for the JSON linter.

Description

This will fix #1008 and allow you to comment in the body of a JSON without the linter showing errors by converting comments to white spaces. By doing that we can conserve the placement of linting errors and still allow comments.

JSON_Lint_Ignore_Comments.mp4

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Sorry, something went wrong.

Strip JSON body of comments and replace them with spaces for the JSON linter.
@n00o n00o force-pushed the bugfix/JSON-Linting-Comments branch from dcecf18 to 67616ca Compare November 25, 2023 09:33
@n00o n00o closed this Nov 25, 2023
@n00o n00o deleted the bugfix/JSON-Linting-Comments branch November 25, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] JSON Linting do not recognize comments
1 participant