Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Empty variable leads to request error #962

Closed
nakaori opened this issue Nov 14, 2023 · 2 comments · Fixed by #963
Closed

[Bug] Empty variable leads to request error #962

nakaori opened this issue Nov 14, 2023 · 2 comments · Fixed by #963

Comments

@nakaori
Copy link

nakaori commented Nov 14, 2023

When an empty variable is configured in the requests vars tab, it leads to the error "Error invoking remote method 'send-http-request': Error: Key is required" which is not really indicative on what to do.

This should either lead to a request that still works anyways or tell me, that i have an empty variable set.

empty
@mikaoelitiana
Copy link
Contributor

@nakaori would the following error makes it clearer?

image

mikaoelitiana added a commit to mikaoelitiana/bruno that referenced this issue Nov 14, 2023
@mikaoelitiana
Improve error message when an empty var is set
500e385 
Fixes usebruno#962
@mikaoelitiana mikaoelitiana mentioned this issue Nov 14, 2023
Merged
5 tasks
@helloanoop helloanoop reopened this Nov 18, 2023
helloanoop added a commit that referenced this issue Nov 18, 2023
@helloanoop
fix(#962): improved error label when name is not defined while settin…
d2a99b0 
…g env var
@nakaori
Copy link
Author

nakaori commented Nov 18, 2023

Perfect. Thanks!

@nakaori nakaori closed this as completed Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve error message when an empty var is set mikaoelitiana/bruno
3 participants
@mikaoelitiana @helloanoop @nakaori