Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: add blacksmith logo #4

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

aayushshah15
Copy link

@aayushshah15 aayushshah15 commented Dec 16, 2024

Important

Add Blacksmith logo to README.md for dark and light modes.

  • Visual Enhancement:
    • Adds Blacksmith logo to README.md for both dark and light modes using HTML <picture> element.

This description was created by Ellipsis for 80c2934. It will automatically update as commits are pushed.

@adityamaru
Copy link

nice!

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 80c2934 in 15 seconds

More details
  • Looked at 18 lines of code in 1 files
  • Skipped 2 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. README.md:4
  • Draft comment:
    Ensure that the image files Blacksmith_Logo-White-Large.png and Blacksmith_Logo-Black-Large.png are present in the root directory. If they are located elsewhere, update the paths accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds a logo to the README file, which is a common practice for branding. However, the logo files are referenced with relative paths, which could lead to broken images if the files are not in the expected location.

Workflow ID: wflow_QEV9AdW546v9RBX7


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@aayushshah15 aayushshah15 merged commit 133fc0b into main Dec 16, 2024
11 checks passed
@aayushshah15 aayushshah15 deleted the 12-16-README_add_blacksmith_logo branch December 16, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants