Remove unnecessary scale + scale-info deps from contracts
#2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ink` umbrella crate re-exports them since a while.
cmichi
added a commit
that referenced
this pull request
Jan 30, 2025
* Remove unnecessary comments
* Fix mismatching return types: `!` vs `{}`
The issue here is that in `std` the function signature of
`return_value` is different from `no_std`.
* Update `scale` deps
* Revert "Update `scale` deps"
This reverts commit 6d4c340.
* Revert "Remove unnecessary `scale` + `scale-info` deps from contracts (#2386)"
This reverts commit b86b693.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
inkumbrella crate re-exports them since ink! v5 (ink::scale,ink::scale_info). No need to depend on them from a contract.See here for more details: https://use.ink/faq/migrating-from-ink-4-to-5/#scale-dependencies-were-moved-to-ink-entrance-crate.