Call ink! contracts from Solidity: support RLP encoding
#2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
3 tasks
|
Not necessary for the first version, but would it make sense to give devs the ability to do a per-message RLP encoding? That way an ink! dev can use full-Rust (scale) for most of the messages, and then expose a couple messages for use by Solidity. They can do this without having to support the entire contract as RLP. |
|
Just documenting here: currently there is a bug when the abi_encoding is "all" and selector is provided by the user. This results in resolved in: 5d2f64d |
peterwht
reviewed
Jan 20, 2025
| C: Callable, | ||
| { | ||
| // todo: handle user provided RLP selector... | ||
| if let Some(selector) = callable.user_provided_selector() { |
There was a problem hiding this comment.
a user provided selector does not rely on encoding, right (equivalent for both scale and RLP)?
If this is the case, this commit should have resolved this TODO: 5d2f64d
cmichi
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.