Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cityseer and osmnx files using the pixi env versions #209

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

martinfleis
Copy link
Contributor

Closes #198

This uses the locked environment from #207 to re-run osmnx and cityseer simplification routines for the sake of reproducibility.

@jGaboardi is our observation correct when we concluded that the workflow we have for cityseer now divereges from the workflow they use internally? Why is that?

@jGaboardi
Copy link
Collaborator

@jGaboardi is our observation correct when we concluded that the workflow we have for cityseer now divereges from the workflow they use internally? Why is that?

I have not had the chance to confirm if it actually diverges. My initial look at the guidelines was that the document layout was significantly different than it had been. But adding in all the OSM tags stuff there could likely account for that.

@martinfleis
Copy link
Contributor Author

I don't mean that it diverges from the user guide but from the implementation that is used within the io module you unpacked in the beginning.

A side observation - new version makes less changes that the old one with the default parameters in SLC.

@jGaboardi
Copy link
Collaborator

I don't mean that it diverges from the user guide but from the implementation that is used within the io module you unpacked in the beginning.

Yeah same. I just haven't have a chance to dig into that yet.

@martinfleis
Copy link
Contributor Author

Okay. Let's merge the current version and then we can revise the implementation later.

@jGaboardi jGaboardi self-requested a review December 5, 2024 14:17
@jGaboardi jGaboardi added the data label Dec 5, 2024
@jGaboardi jGaboardi merged commit a4b2bcc into main Dec 5, 2024
2 checks passed
@jGaboardi jGaboardi deleted the data-update branch December 5, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update cityseer data
2 participants