beef up FAI detection related parameter explanations – #110 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jGaboardi thanks for the deciphering!! i did a second pass on the parameter documentation - but now I think it needs a third 😅 as in: it is factually correct now but potentially too detailed / verbose |
anastassiavybornova
requested changes
Dec 5, 2024
|
I'm fine with @anastassiavybornova version. |
|
Do not merge. Still reviewing. |
|
Won't, also due to
|
jGaboardi
commented
Dec 5, 2024
There was a problem hiding this comment.
Very nice @anastassiavybornova . Small language changes and little typos only.
|
@anastassiavybornova Would you like to review my suggestions or shall I commit them myself? (still need to update the other docstrings after that). |
Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
|
@jGaboardi reviewing them now! |
|
@jGaboardi done |
|
I'll merge this once CI is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*_threshold_*params insimply.simplify_network()#110simplify_network()are accurate & make sense, I'll cascade them into internal functions prior to merging.