Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean integer index when returning nodes.remove_false_nodes() #90

Closed
jGaboardi opened this issue Nov 15, 2024 · 1 comment · Fixed by #91
Closed

clean integer index when returning nodes.remove_false_nodes() #90

jGaboardi opened this issue Nov 15, 2024 · 1 comment · Fixed by #91
Assignees
@jGaboardi
Labels
refactor & code maint

Comments

@jGaboardi
Copy link
Collaborator

jGaboardi commented Nov 15, 2024 •
edited
Loading

Not critical, but it would be nice to return a clean integer index when returning nodes.remove_false_nodes(). This helps with granular testing and troubleshooting when bugs crop up.
@jGaboardi jGaboardi self-assigned this Nov 15, 2024
jGaboardi added a commit that referenced this issue Nov 15, 2024
@jGaboardi
granular test for nodes.fix_topology -- + #90
65a8da6
@jGaboardi jGaboardi mentioned this issue Nov 15, 2024
Merged
@jGaboardi jGaboardi changed the title clean integer index when returning nodes.remove_false_nodes () clean integer index when returning nodes.remove_false_nodes() Nov 15, 2024
@jGaboardi
Copy link
Collaborator Author

Actually will add this to nodes.remove_false_nodes() itself.

martinfleis pushed a commit that referenced this issue Nov 18, 2024
@jGaboardi
granular test for nodes.fix_topology() (#91)
41f7d97 
* running commit

* granular test for nodes.fix_topology -- + #90

* add reset index to remove_false_nodes()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jGaboardi jGaboardi

Labels
refactor & code maint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

granular test for nodes.fix_topology() uscuni/neatnet
1 participant
@jGaboardi