Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another run at static final #5

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Another run at static final #5

merged 5 commits into from
Mar 22, 2024

Conversation

ChrisHegarty
Copy link

:-)

@ChrisHegarty ChrisHegarty mentioned this pull request Mar 22, 2024
Merged
@ChrisHegarty
Copy link
Author

@uschindler - ok if you don't want it, but wanted to get your opinion.

@uschindler
Copy link
Owner

Much better:

  • the logger in base class is obsolete now
  • I would rename the static final MH to uppercase, because its static: MH$posix_madvise

Otherwise it looks fine. When moving to Optional<NativeAccess> I had something siliar in my head... +1

@ChrisHegarty ChrisHegarty merged commit 5c97ca0 into uschindler:dev/posix_madvise Mar 22, 2024
@uschindler
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisHegarty @uschindler