Set randomAccess=true on LOAD. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -90,6 +90,9 @@ private IOContext(boolean readOnce, boolean load, boolean randomAccess) { | |||
| if (readOnce && randomAccess) { | |||
| throw new IllegalArgumentException("cannot be both readOnce and randomAccess"); | |||
| } | |||
| if (load && randomAccess == false) { | |||
| throw new IllegalArgumentException("cannot be load but not randomAccess"); | |||
There was a problem hiding this comment.
Trivially, maybe add something like this to the javadoc for load:
If this flag is set, then randomAccess will be true.
… use are Poxix only. On Windows we can have a totally different way to madvise the kernel
|
@uschindler Would you like to take a look? |
62c708e to
a729f02
Compare
|
I fixed the conflict. Sorry for force-pushing the main PR. I was not aware that you were working. |
uschindler
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.