Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time entry edit dialog #1029

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Time entry edit dialog #1029

wants to merge 9 commits into from

Conversation

derTobsch
Copy link
Contributor

@derTobsch derTobsch commented Jan 10, 2025 •
edited
Loading

Here are some things you should have thought about:

Multi-Tenancy

  • Extended new entities with AbstractTenantAwareEntity?
  • New entity added to TenantAwareDatabaseConfiguration?
  • Tested with dev-multitenant profile?

closes #477

bseber added 9 commits January 10, 2025 08:49
@bseber
introduce TimeEntryControllerHelper
891eaf5
@bseber
rename ControllerHelper to ViewHelper
5397e3e 
shorter name
@bseber
add first time entry edit dialog prototype
11971eb
@bseber
edit TimeEntry via report view, including form validation
d8844f2
@bseber
edit timeEntry instead of creating new one, ease html template using *{}
05c5236 
labels are not printed red anymore. however, templates are easier.
@bseber
try to improve SPA feeling with time-entry edit dialog
dee5ed4 
thoughts / architecture

- only one dialog/modal exists on the page
- dialog is reachable via URL just like a normal website
  - progressively enhanced with js to improve UX, actually just keeping the scroll position

workflow

- clicking edit, loads next page
- turbo renders the frame-modal and advances the url
  - browser back -> closes the dialog and removes the history entry
  - x does the same
  - 'close dialog' button does the same
  - 'save' loads the next page, turbo renders the full page. custom js keeps scroll position
  - in case of validation exceptions
    - only dialog is visible, the report page is lost
    - going back or saving the time-entry renders report page with scroll position on top
      (not nice, but we don't need some fancy techniques to solve this one problem currently)

TODOs (maybe):

- 'restore' form does not work after validation exceptions
  - this button would have to reload the page, however, scroll position is lost with JS in this case
@bseber
introduce TimeEntryEditModalHelper
b9b00a5 
time entry edit modal could be / will be visible on TimeEntry view, too.
@bseber
add TimeEntryHistoryDto, still hard coded
43b21e4
@bseber
add time entry edit modal messages
1ea30c1
@derTobsch derTobsch marked this pull request as draft January 10, 2025 10:13
@derTobsch derTobsch added this to the 2.15.0 milestone Jan 10, 2025
@github-actions github-actions bot added the status: planned This issue is planned in a milestone and won't be touched by stale bot. label Jan 10, 2025
@honnel honnel modified the milestones: 2.15.0, 2.16.0 Jan 10, 2025
@github-actions github-actions bot added status: new Initial state for every issue / pullrequest status: planned This issue is planned in a milestone and won't be touched by stale bot. and removed status: planned This issue is planned in a milestone and won't be touched by stale bot. status: new Initial state for every issue / pullrequest labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: planned This issue is planned in a milestone and won't be touched by stale bot.
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

Änderungshistorie an Zeiteinträgen
3 participants
@derTobsch @honnel @bseber