Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix calculation of calendar weeks #1023

Merged
merged 4 commits into from
Jan 6, 2025
Merged

fix calculation of calendar weeks #1023

merged 4 commits into from
Jan 6, 2025

Conversation

bseber
Copy link
Contributor

@bseber bseber commented Jan 3, 2025

fix #1018

Here are some things you should have thought about:

Multi-Tenancy

  • Extended new entities with AbstractTenantAwareEntity?
  • New entity added to TenantAwareDatabaseConfiguration?
  • Tested with dev-multitenant profile?

@bseber bseber added this to the 2.14.2 milestone Jan 3, 2025
@github-actions github-actions bot added the status: planned This issue is planned in a milestone and won't be touched by stale bot. label Jan 3, 2025
@bseber bseber force-pushed the 1018-fix-calendar-week branch from f3b267b to af15442 Compare January 3, 2025 15:44
@derTobsch derTobsch force-pushed the 1018-fix-calendar-week branch from af15442 to f7932bd Compare January 6, 2025 09:24
@bseber @derTobsch
fix calculation of calendar weeks
4dfb71f 
TimeEntryWeek `int week()` uses hard coded Locale.GERMANY because unit test is only green with this locale.
it does not work with Locale.forLanguageTag()... I don't get it...

therefore using hard coded locale to fix this issue...
we may have to have a look at this in the future?
@derTobsch derTobsch force-pushed the 1018-fix-calendar-week branch from f7932bd to 4dfb71f Compare January 6, 2025 09:30
@derTobsch
Copy link
Contributor

derTobsch commented Jan 6, 2025 •
edited
Loading

Unter Zeit sieht es nun gut aus:

image

Aber unter Berichte ist die aktuelle Woche nun die KW1. Hier sollte KW2 stehen

Screencast.From.2025-01-06.12-33-12.webm

siehe 9e264a1 - kannst du dir das anschauen @bseber?

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@derTobsch derTobsch merged commit bafd63c into main Jan 6, 2025
7 checks passed
@derTobsch derTobsch deleted the 1018-fix-calendar-week branch January 6, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: planned This issue is planned in a milestone and won't be touched by stale bot.
Projects
None yet
Milestone
2.14.2
Development

Successfully merging this pull request may close these issues.

Change between years is not correctly depicted
2 participants
@bseber @derTobsch