This repository has been archived by the owner on Mar 29, 2022. It is now read-only.
Split send payloads according to firebase's custom continuation format #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Uri -
While using firebase-server we noticed that long messages being sent back from the web server were failing on the Java Firebase client. It turns out they have implemented a custom frame-chunking protocol as you can see here: https://github.com/firebase/firebase-admin-java/blob/d4a143801cf73e0de9641d29da9c5e72d1f91944/src/main/java/com/google/firebase/database/connection/WebsocketConnection.java#L124-L217. This PR sends long messages in chunks and fixes our problem.
Thanks for a great tool!