Migrate to Targaryen 3 #100
Conversation
|
For some story on it, I ran into an issue with Targaryen 2.3.3 with [1] https://github.com/goldibex/targaryen/blob/v2.3.3/lib/ruleset.js#L308 |
|
Thanks, Is that a breaking change in any way? |
|
Hopefully not, but Nothing is expected to break according to their CHANGELOG.md - it is only listing a number of fixes. BTW the issue I had with 2.3.3 is goldibex/targaryen#73. |
|
A friendly ping! |
|
Have you seen my question above? |
|
@urish just the one about whether it's a breaking change, but I've replied to it with as much information I have. Is there anything else I can do? |
|
@dotdoom regarding this line: Can you explain? |
|
@urish this is a finding unrelated to this PR. An authentic Firebase server will cancel listeners server-side if a client no longer has a read permission to a specific node. This can happen either after a write to the database, or after a security rules change. If we want to replicate a similar behavior with minimum effort, we could A better approach would be to store all the listeners and verify legibility of each of them on every write to the database, even if the write goes to a different node. That would replicate the exact behavior of Firebase server I've noticed in practice. |
* fbRef is kept for its listener |on('value')| implementation
* keeping _targaryen object around at all times, since setRules can be
invoked at any time, and we need targaryen internal database to be
up-to-date
* tryXxx are now synchronous as they don't need to fetch value from
fbRef
Suggest looking at the diff with "?w=1" (ignore whitespace diff)
appended to the GitHub URL.
|
Got it, thanks! |
|
released as 0.11.0 |
* fbRef is kept for its listener |on('value')| implementation
* keeping _targaryen object around at all times, since setRules can be
invoked at any time, and we need targaryen internal database to be
up-to-date
* tryXxx are now synchronous as they don't need to fetch value from
fbRef
Suggest looking at the diff with "?w=1" (ignore whitespace diff)
appended to the GitHub URL.
* origin/master: chore: release 0.11.0 chore: add package-lock.json doc: add a note about `-s` argument doc: add link to explain tryRead() issue Migrate to Targaryen 3 (urish#100) Support passing a WebSocket.Server options object to the FirebaseServer constructor (urish#101) Fix security rules validation for updates (urish#99)
invoked at any time, and we need targaryen internal database to be
up-to-date
fbRef
Suggest looking at the diff with "?w=1" (ignore whitespace diff)
appended to the GitHub URL.