This repository has been archived by the owner on Oct 1, 2023. It is now read-only.
Added support for expressions in attributes #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for expressions in spinner-key attribute (i.e. spinner-key="{{spinnerKey}}") Attributes exposed to the controller of a directive will not interpolate expressions. If an expression is provided for an attribute that is being passed into the controller the only way to interpolate it is to use $attrs.$observe() or $scope.$eval() which is evil.
According to the Angular documentation, it is a best practice to "use controller when you want to expose an API to other directives. Otherwise use link." (see: https://docs.angularjs.org/guide/directive (very bottom of the page).
urish
added a commit
that referenced
this pull request
Apr 25, 2014
Added support for expressions in attributes
|
Thanks @aaronroberson ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for expressions in spinner-key attribute (i.e. spinner-key="{{spinnerKey}}") Attributes exposed to the controller of a directive will not interpolate expressions. If an expression is provided for an attribute that is being passed into the controller the only way to interpolate it is to use $attrs.$observe() or $scope.$eval() which is evil.
According to the Angular documentation, it is a best practice to "use controller when you want to expose an API to other directives. Otherwise use link." (see: https://docs.angularjs.org/guide/directive (very bottom of the page).