This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
Update init to take features parameter: Map<String, GBFeature> #17
+72
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c0df97 to
7e51216
Compare
RyanHedges
reviewed
Apr 13, 2023
| {Map<String, dynamic>? seeds, | ||
| {Map<String, GBFeature> features = const <String, GBFeature>{}, | ||
| @Deprecated('Instead use "features" as Map<String, GBFeature>') | ||
| Map<String, dynamic> seeds = const <String, dynamic>{}, |
There was a problem hiding this comment.
Why does initForTests not need the combining finalFeatures and seeds functionality that is being done in init? It looks like _createTestClient gets the seeds and features is never used. Is that correct?
pubspec.yaml
Outdated
| growthbook_sdk_flutter: | ||
| git: | ||
| url: https://github.com/uptech/GrowthBook-SDK-Flutter.git | ||
| ref: master |
There was a problem hiding this comment.
We'll see if we need to go this direction based on the responsiveness of the maintainers of the GrowthBook-SDK-Flutter.
| if (seeds.isNotEmpty) { | ||
| seeds.forEach((key, value) { | ||
| finalFeatures[key] = GBFeature(defaultValue: value); | ||
| }); |
There was a problem hiding this comment.
I don't see any tests that ensure that seeds are still valid, and that they populate growthbook correctly (because they are merged here). Should they be added?
Recently the growthbook_sdk_flutter package was updated. This change removed the ability to "seed" the feature values which are used while the network request is happening or as fallback if the request fails. Alongside this work, I have updated the Uptech fork of growthbook_sdk_flutter to allow passing in "seeded" features and values at init, instead of after. This commits points the dependency at the Uptech fork, which is still in review. Add features param to init constructor. Add Deprecated tag to seeds so we know, while it is still possible to use that parameter, we should be using features. Add comments explaining why we have both params and what changes in the growthbook_sdk_flutter package inspired these changes. If a Map is passed in to the seeds param, we convert them to the new feature Map<String, GBFeature> and pass that map along. Update the tests to use GBFeature for map values. <!-- ps-id: 9fb1da74-fa5f-4ba5-a05e-ddebf7f970b6 -->
7e51216 to
b1d9a30
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the growthbook_sdk_flutter package was updated. This change
removed the ability to "seed" the feature values which are used while
the network request is happening or as fallback if the request fails.
Alongside this work, I have updated the Uptech fork of
growthbook_sdk_flutter to allow passing in "seeded" features and
values at init, instead of after. This commits points the dependency
at the Uptech fork, which is still in review.
Add features param to init constructor.
Add Deprecated tag to seeds so we know, while it is still possible to
use that parameter, we should be using features.
Add comments explaining why we have both params and what changes in
the growthbook_sdk_flutter package inspired these changes.
If a Map is passed in to the seeds param, we convert them to the new
feature Map<String, GBFeature> and pass that map along.
Update the tests to use GBFeature for map values.