Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to Remain in CRAN Compliance #92

Merged
merged 4 commits into from
Apr 30, 2018
Merged

Changes to Remain in CRAN Compliance #92

merged 4 commits into from
Apr 30, 2018

Conversation

bburns632
Copy link
Collaborator

This PR will solves some CRAN compliance issues (such as in #78 & #83) and solve some rendering issues with latest pandoc.

Changes for CRAN:

  1. Report is saved in the temp directory in CreatePackageReport()
  2. Vignette does write to user R library (since test packages are not installed in the official vignette)

Changes to Reports:

  1. CreatePackageReport() opens final html report by default
  2. Titles added to reports (a requirement with updated rmarkdown and pandoc)
  3. rmarkdown minimum version enforced.

This PR replaces PR #90

@bburns632 bburns632 mentioned this pull request Apr 28, 2018
Closed
@bburns632 bburns632 requested review from jameslamb, patrick-boueri and jayqi and removed request for patrick-boueri April 28, 2018 23:21
jameslamb
jameslamb approved these changes Apr 29, 2018
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, sir

@bburns632 bburns632 merged commit 5f43ab6 into uptake:master Apr 30, 2018
@bburns632 bburns632 mentioned this pull request Aug 1, 2018
Merged
@jameslamb jameslamb mentioned this pull request Nov 6, 2018
Closed
@bburns632 bburns632 deleted the feature/passCran branch December 19, 2018 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayqi jayqi jayqi approved these changes

@jameslamb jameslamb jameslamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bburns632 @jayqi @jameslamb