Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/lazy data resolves #288 #289

Merged
merged 3 commits into from
Dec 21, 2021
Merged

Bugfix/lazy data resolves #288 #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1979471
bugfix: update LazyData field for revised CRAN policy
brian-burns-tc May 20, 2021
e07867f
testing: switched to the drd image from rocker for slightly faster r-…
brian-burns-tc May 20, 2021
0eafb48
Update NEWS.md
bburns632 May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ Check in whichever of the files generated by `pkgdown` seem relevant to you. Any

### Test on latest development version of R (i.e. "R-Devel")

This is a CRAN requirement, and yes, it's a pain. Luckily, Dirk Eddelbuettel and friends maintain docker images to make this process (a little) easier. Specifically, the [rocker/r-devel](https://hub.docker.com/r/rocker/r-devel) image provides a great jumping off point. Note, this image is rebuilt every few days, so if you _absolutely need_ to have _bleeding edge_ r-devel and have a extra hour to spare, follow [this docker process](https://alexandereckert.com/post/testing-r-packages-with-latest-r-devel/) from Alexander Eckert.
This is a CRAN requirement, and yes, it's a pain. Luckily, Dirk Eddelbuettel and friends maintain docker images to make this process (a little) easier. Specifically, the [rocker/drd](https://hub.docker.com/r/rocker/drd) image from [the Rocker Project](https://www.rocker-project.org/images/) provides a great jumping off point. It's a lighter r-devel image. Note, this image is rebuilt every few days, so if you _absolutely need_ to have _bleeding edge_ r-devel and have a extra hour to spare, follow [this docker process](https://alexandereckert.com/post/testing-r-packages-with-latest-r-devel/) from Alexander Eckert.

1. Navigate to the base directory of the package.
2. Build the r-devel pkgnet docker image and run CRAN checks via these commands:
Expand Down
1 change: 0 additions & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,4 @@ Suggests:
License: BSD_3_clause + file LICENSE
URL: https://github.com/uptake/pkgnet, https://uptake.github.io/pkgnet/
BugReports: https://github.com/uptake/pkgnet/issues
LazyData: TRUE
RoxygenNote: 7.1.0
7 changes: 6 additions & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# pkgnet (dev)
## NEW FEATURES
* Node coloring in DependencyReporter (#243)

## CHANGES
* Removed LazyData field to accomodate change in CRAN policy. (#289)

_No changes since latest release_
## BUGFIXES

# pkgnet 0.4.1

Expand Down
2 changes: 1 addition & 1 deletion release_testing/dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# intended build command to be run from package root:
# docker build -f release_testing\dockerfile -t pkgnet_rdevel .

FROM rocker/r-devel
FROM rocker/drd

# Copy test script into container
COPY release_testing/r_devel_check.sh .
Expand Down